[MRG] FIX towards disregarding multi_class in the case of binary y #11868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I messed with your PR. Feel free to over write. I have to check how your changes are different... |
|
ok this looks right (mine passes the tests but might have an issue with warm-starting in the binary case?). |
|
wdyt about the discussion in #11476 ? |
amueller
approved these changes
Aug 20, 2018
|
@jnothman Could you please confirm that we still want to merge this after your comment in #11476 (comment) ? Thanks. |
|
No, I'll adapt the test though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually works, unlike #11859. Not overwriting that branch because it now has @amueller's changes.