[MRG+1] break the tie in Meanshift in case cluster intensities are the same #11901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting. can we add a more specific test for this? also, if we're going
to fix for release, please update what's new
|
|
yeah, I added a test for that case. Which is basically the example which was failing. |
jnothman
approved these changes
Aug 23, 2018
|
Please add an entry to the change log at |
|
This doesn't lead to a failure right now so isn't critical, right? |
|
Well it was leading to a failure. Did they change? |
|
It's only not failing because we're not running the doctests. The test case
here would presumably fail on some platforms. So if you want it to be
critical, we can add the test case without the fix :p
|
|
LGTM as well, indeed it's useful to merge for 0.20 because of #12014. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 6, 2018
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See MacPython/scikit-learn-wheels#7 (comment)
MeanShift is undeterministic if intensities of clusters are the same. This uses the cluster center values to sort in case of a tie.