Skip to content

[MRG+2] OPTICS: change max_bound -> max_eps #11984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2018
Merged

[MRG+2] OPTICS: change max_bound -> max_eps #11984

merged 1 commit into from
Sep 3, 2018

Conversation

adrinjalali
Copy link
Member

qinhanmin2014
qinhanmin2014 approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @adrinjalali , will merge when green (I've restarted Travis for you)

@qinhanmin2014
Copy link
Member

@jnothman I assume we can change our API without deprecation warning between RC and the final release.

@jnothman
Copy link
Member

jnothman commented Sep 3, 2018 via email

@adrinjalali adrinjalali changed the title OPTICS: change max_bound -> max_eps [MRG+2] OPTICS: change max_bound -> max_eps Sep 3, 2018
@qinhanmin2014 qinhanmin2014 merged commit 721ebae into scikit-learn:master Sep 3, 2018
@adrinjalali adrinjalali deleted the optics/max_eps branch September 3, 2018 14:58
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Sep 4, 2018
@adrinjalali @jnothman
MNT Change max_bound -> max_eps in OPTICS (scikit-learn#11984)
fea3f30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinjalali @qinhanmin2014 @jnothman