[MRG] Remove Python < 3.5 from continuous integration #11995
Conversation
#### Reference Issues/PRs Fixes #11989 #### What does this implement/fix? Removes python versions 2/3.4 and lower from CI config files.
| - python-scipy | ||
| - libatlas3-base | ||
| - libatlas-dev | ||
| # Python 3.4 build |
There was a problem hiding this comment.
We still need a run with minimum requirements, so make sure that we have a python 3.5 run and that minimum / alternative variants of dependencies are still tested
There was a problem hiding this comment.
Do you think it would be fine to update this to remove the python2 env, but change 3.4 to 3.5? It looks like we're only testing the 'ubuntu' distribution under python 2, so we could move that up to 3.5 as well, unless we don't want to support that going further?.
There was a problem hiding this comment.
I think we still want to support Ubuntu LTS package distributions. Can you check whether trusty providers python 3.5+ with those same numpy/scipy releases?
|
Thanks for tackling this! |
|
Just a note that this shouldn't be merged before the final 0.20 release, and I would argue we could even wait for 0.20.1 to make backports easier, as I'm not sure how many people actually test 0.20.rc1.. |
|
Yes, I suppose I was jumping the gun in opening those issues today...
|
.circleci/config.yml
Outdated
| - NUMPY_VERSION: 1.8.2 | ||
| # XXX: plot_gpc_xor.py fails with scipy 0.13.3 | ||
| - SCIPY_VERSION: 0.14 | ||
| - MATPLOTLIB_VERSION: 1.3 |
There was a problem hiding this comment.
I wonder whether we should continue to test support for matplotlib 1.x
| - python-scipy | ||
| - libatlas3-base | ||
| - libatlas-dev | ||
| # Python 3.4 build |
There was a problem hiding this comment.
I think we still want to support Ubuntu LTS package distributions. Can you check whether trusty providers python 3.5+ with those same numpy/scipy releases?
|
I think we should do this now, but there have been changes to circle and travis configs that have caused merge conflicts, sorry @abbygrbl. You also haven't responded to #11995 (comment). Would you like someone else to take this issue? |
|
Sorry about that, I will close this out. |
|
Hi @abbygrbl, we would be very happy if you would like to continue your work here. But it required changes before merge. I take it you would like someone else to complete it? |
Reference Issues/PRs
Fixes #11989
What does this implement/fix?
Removes python versions 2/3.4 and lower from CI config files.