Skip to content

Conversation

Olamyy
Copy link

@Olamyy Olamyy commented Sep 5, 2018

Reference Issues/PRs

Fixes #11996

What does this implement/fix? Explain your changes.

Currently contains 3 edits:

  1. Tests to check handle_missing and missing_values are passed and have correct values
  2. An update to the OneHotEncoder docstring and the preprocessing module.
  3. An initial implementation logic of the required features as stated by Handle missing values in OneHotEncoder #11996

olamilekan added 2 commits September 5, 2018 14:38
Inital Tests Implementation

Docstring and doc modules update
@jnothman
Copy link
Member

jnothman commented Sep 6, 2018

You're doing something very strange here: CategoricalEncoder does not exist in master, and will not exist. It has been replaced by enhancements to OneHotEncoder and a new OrdinalEncoder

@Olamyy
Copy link
Author

Olamyy commented Sep 6, 2018

Yeah.

I have a huge merge issue. My local copy was behind by a couple of commits and I forgot to update it.

I will fix that and make a new PR very soon.

@Olamyy
Copy link
Author

Olamyy commented Sep 6, 2018

The new PR is #12025 . I'm going to go ahead and close this one now.

@Olamyy Olamyy closed this Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle missing values in OneHotEncoder
2 participants