Skip to content

[MRG] Fix docstring inconsistency for NMF #12063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2018
Merged

[MRG] Fix docstring inconsistency for NMF #12063

merged 1 commit into from
Sep 13, 2018

Conversation

zjpoh
Copy link
Contributor

@zjpoh zjpoh commented Sep 13, 2018

non_negative_factorization in sklearn/decomposition/nmf.py has default init='random' but the docstring says Default: 'nndsvd' if n_components < n_features, otherwise random..

Reference Issues/PRs

See #12062 and #11667

What does this implement/fix? Explain your changes.

Modified docstring.

adrinjalali
adrinjalali approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zjpoh, LGTM!

qinhanmin2014
qinhanmin2014 approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zjpoh

@qinhanmin2014 qinhanmin2014 merged commit dad5c36 into scikit-learn:master Sep 13, 2018
@qinhanmin2014 qinhanmin2014 mentioned this pull request Sep 13, 2018
Closed
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Sep 17, 2018
@zjpoh @jnothman
DOC Fix docstring inconsistency in nmf.py (scikit-learn#12063)
c625dc1
@zjpoh zjpoh deleted the nmf-docstring-fix branch January 16, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjpoh @adrinjalali @qinhanmin2014