It seems to be alive now.

Hi,

It looks like we weren't receiving webhooks about the scikit-learn repository. Is it possible the webhook was deactivated in the GitHub web interface?

I'm glad the integration appears to be working again for you now.

Thanks,
Chris from LGTM

And we've grown a lot of alerts (mostly with thanks to liac-arff and joblib!)

I saw that too. Reported it to https://github.com/tomMoral/loky/issues/172, for liac-arff it doesn't seem too relevant.

BTW, @chrisgavin if I look at false positives, the following ones happen quite often,

import io
from io import StringIO

will raise a warning Module 'io' is imported with both 'import' and 'import from' (I think), while IMO it shouldn't, it's a fairly common pattern.

Another thing is,

try:
  something
except:  # noqa: E722
  something else

or,

except BaseException:

will raise Except block directly handles BaseException. while that's explicitly what we want here.

I can report it somewhere else if that would be more appropriate, but e.g. https://github.com/lgtmco/lgtm appears archived..

The right place to report issues would be https://github.com/Semmle/ql or https://discuss.lgtm.com/ . I'll ask a team member to have a look at the issues you reported.

Thanks,
Arthur from LGTM

did we change to having lgtm comment again instead of having the direct integration?

Maybe it was just a matter of me doing very large changes. Let's see if it keeps being annoying? ;)