Skip to content

Fix parallel backend neighbors #12172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2018

Conversation

tomMoral
Copy link
Contributor

Fixes #12171

This forces the joblib backend to threading in neighbors for python2.7 as the KDTree and BallTree methods are not picklable.

@ogrisel ogrisel modified the milestones: 0.21, 0.20.1 Sep 27, 2018
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this fix should be backported to 0.20.1. @tomMoral Could you please add what's new entry?

@tomMoral tomMoral force-pushed the FIX_parallel_backend_neighbors branch from 486c95d to b9c3fcb Compare September 27, 2018 08:33
@ogrisel ogrisel merged commit 88b49e5 into scikit-learn:master Sep 27, 2018
@ogrisel
Copy link
Member

ogrisel commented Sep 27, 2018

This will require to be included in the future 0.20.1 backport PR.

@tomMoral tomMoral deleted the FIX_parallel_backend_neighbors branch September 27, 2018 12:34
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants