adding SVC documentation references #12217
Conversation
|
|
||
| probA_, probB_ : array, shape = [n_class * (n_class-1) / 2] | ||
|
|
||
| If probability=True, the parameters learned in Platt scaling to |
There was a problem hiding this comment.
The indentation seems off. Also you can refer to the user guide that also explains that, though it's good to also mention the paper.
| where ``probA_`` and ``probB_`` are learned from the dataset. For more | ||
| information on the multiclass case and training procedure see section | ||
| 8 of LIBSVM: A Library for Support Vector Machines (in References) | ||
| for more. |
There was a problem hiding this comment.
for more is repeated twice here
| @@ -578,6 +594,11 @@ class SVC(BaseSVC): | |||
| implemented using liblinear. Check the See also section of | |||
| LinearSVC for more comparison element. | |||
|
|
|||
| References | |||
There was a problem hiding this comment.
Shoud Platt (2000) be added as well? i.e. "Probabilistic outputs for support vector machines and comparison to regularizedlikelihood methods."
|
Hello @cynco , Thank you for participating in the WiMLDS/scikit sprint. We would love to merge all the PRs that were submitted. It would be great if you could follow up on the work that you started! For the PR you submitted, would you please update and re-submit? Please include #wimlds in your PR conversation. Any questions:
cc: @reshamas |
|
Hi there. Thanks for the message and apologies for the insane delay in
finishing it. It’s on top of my list for this holiday break!
Happy holidays!
…On Sun, Nov 11, 2018 at 11:40 AM Sergul Aydore ***@***.***> wrote:
Hello @cynco <https://github.com/cynco> ,
Thank you for participating in the WiMLDS/scikit sprint. We would love to
merge all the PRs that were submitted. It would be great if you could
follow up on the work that you started! For the PR you submitted, would you
please update and re-submit? Please include #wimlds in your PR conversation.
Any questions:
- see workflow
<https://github.com/WiMLDS/nyc-2018-scikit-sprint/blob/master/2_contributing_workflow.md>
for reference
- ask on this PR conversation or the issue tracker
- ask on wimlds gitter <https://gitter.im/scikit-learn/wimlds> with a
reference to this PR
cc: @reshamas <https://github.com/reshamas>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12217 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACdsPvo5z4pu6Za4UCTVsOjhMaJKrb4-ks5uuFLsgaJpZM4XAqAU>
.
|
|
Hello @cynco |
|
I am taking over this PR. |
|
I fixed it around Thanksgiving break; it just needs to be reviewed.
Apologies - I must have not made the push request correctly.
…On Tue, Dec 18, 2018 at 6:43 PM Tashay Green ***@***.***> wrote:
I am taking over this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12217 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACdsPrSvbrY3eVnT5Xw29UWji1mqzAjEks5u6YvKgaJpZM4XAqAU>
.
|
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?