This pull request introduces 161 alerts when merging 14acab6 into 2cf145d - view on LGTM.com

new alerts:

• 55 for Property in old-style class
• 16 for Module is imported with 'import' and 'import from'
• 12 for First argument of a method is not named 'self'
• 10 for Unused import
• 9 for Conflicting attributes in base classes
• 8 for Unused local variable
• 6 for Unnecessary 'else' clause in loop
• 5 for Should use a 'with' statement
• 5 for Missing call to __init__ during object initialization
• 4 for Unreachable code
• 4 for Wrong name for an argument in a class instantiation
• 3 for __eq__ not overridden when adding attributes
• 3 for Signature mismatch in overriding method
• 3 for Comparison using is when operands support __eq__
• 3 for Variable defined multiple times
• 2 for Wrong name for an argument in a call
• 2 for Module imports itself
• 2 for Nested loops with same variable
• 1 for Use of the return value of a procedure
• 1 for Except block handles 'BaseException'
• 1 for Import of deprecated module
• 1 for Modification of parameter with default
• 1 for 'input' function used
• 1 for Implicit string concatenation in a list
• 1 for Mismatch between signature and use of an overridden method
• 1 for Wrong number of arguments in a class instantiation
• 1 for Unguarded next in generator

Comment posted by LGTM.com

Something didn't go right here, It's showing 489 files changed.

Seems like the virtualenv is added to the repo. @blooraspberry, to be on the safe side, you can always create your virtualenv not in the same folder as you have the scikit-learn clone. git rm -r sklearndev should fix the issue.

Hello @blooraspberry ,

Thank you for participating in the WiMLDS/scikit sprint. We would love to merge all the PRs that were submitted. It would be great if you could follow up on the work that you started! For the PR you submitted, would you please update and re-submit? Please include #wimlds in your PR conversation.

Any questions:

• see workflow for reference
• ask on this PR conversation or the issue tracker
• ask on wimlds gitter with a reference to this PR

cc: @reshamas

@amueller

1. Is adding the classes_ definition all that is required?
2. I didn't see a reference to an issue.
3. If that is all that needs to be done, I can complete it. But, if there is something else, can you specify?

    Attributes
    ----------	    ----------
     classes_ : array or shape (n_classes, )
        A list of class labels known to the classifier.
        
        In binary classification, one class is usually considered the 'positive' 
        class. For example, in labels [-1, 1], 1 is the positive class. 

@jnothman Since there has been no response from @blooraspberry after multiple attempts to contact her, I will complete this PR.

And since there are 450+ files included here, would it be best if I opened a new PR, or do you think I can clean up the Git files in a new branch?

cc: @sergulaydore

@reshamas either starting over or just removing the sklearn-dev folder should be pretty straight-forward.