ck estimator is classifier & num_classes>=2 in score.py #12221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Sep 29, 2018
| @@ -183,7 +183,12 @@ def __call__(self, clf, X, y, sample_weight=None): | |||
| y_pred = clf.predict_proba(X) | |||
|
|
|||
| if y_type == "binary": | |||
| y_pred = y_pred[:, 1] | |||
| if y_pred.shape[1]==2: | |||
There was a problem hiding this comment.
Can you please run flake8 on this file? There are some formatting issues.
|
Looks good in general, but you need to add a regression test (you could use the GMM one or just a classification one with a single class maybe) |
|
Thanks for your feedback, will do it soon.
On Sat 29 Sep 2018 at 17:36, Andreas Mueller ***@***.***> wrote:
Looks good in general, but you need to add a regression test (you could
use the GMM one or just a classification one with a single class maybe)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12221 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AlCeRE4pCeU1nUuA-TSqV-sjZl8XJpiMks5uf-fagaJpZM4XAqk->
.
--
*Alice MARTIN*
Data Scientist - Paris, France
adresse email pro: alice.martindonati.pro@gmail.com
https://www.linkedin.com/in/alicemartindonati
https://github.com/AMDonati
|
|
@AMDonati I am happy to get on a zoom or google hangouts meeting so we can run the checks. Let me know what works for you. My email: reshama@wimlds.org |
|
@reshamas , I will try to close it tomorrow. |
|
Hello @AMDonati , Thank you for participating in the WiMLDS/scikit sprint. We would love to merge all the PRs that were submitted. It would be great if you could follow up on the work that you started! For the PR you submitted, would you please update and re-submit? Please include #wimlds in your PR conversation. Any questions:
cc: @reshamas |
|
Hi Sergul,
All my apologies for not having answering your request: I have been
travelling for the last 10 days with very few access to internet, and
without a laptop to be able to do anything on github.
I will see what is the status of the PR requests and see how I can merge
them starting from today.
On Sun 11 Nov 2018 at 17:41, Sergul Aydore ***@***.***> wrote:
Hello @AMDonati <https://github.com/AMDonati> ,
Thank you for participating in the WiMLDS/scikit sprint. We would love to
merge all the PRs that were submitted. It would be great if you could
follow up on the work that you started! For the PR you submitted, would you
please update and re-submit? Please include #wimlds in your PR conversation.
Any questions:
- see workflow
<https://github.com/WiMLDS/nyc-2018-scikit-sprint/blob/master/2_contributing_workflow.md>
for reference
- ask on this PR conversation or the issue tracker
- ask on wimlds gitter <https://gitter.im/scikit-learn/wimlds> with a
reference to this PR
cc: @reshamas <https://github.com/reshamas>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12221 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AlCeRAbaSBVR89wp39Kx2gT2BsJZvWUEks5uuFNKgaJpZM4XAqk->
.
--
*Alice MARTIN*
Data Scientist - Paris, France
adresse email pro: alice.martindonati.pro@gmail.com
https://www.linkedin.com/in/alicemartindonati
https://github.com/AMDonati
|
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Nov 20, 2018
…orer (scikit-learn#12486) Continues and resolves scikit-learn#12221, fixes scikit-learn#7598
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…orer (scikit-learn#12486) Continues and resolves scikit-learn#12221, fixes scikit-learn#7598
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
…orer (scikit-learn#12486) Continues and resolves scikit-learn#12221, fixes scikit-learn#7598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
We are fixing this issue: #7598
We added a test in the scorer.py file that raises a ValueError if the user is either trying to use a non classifier model for a classification problem, or is using a dataset with only one class.
Any other comments?
@reshamas