[MRG] FIX row_norms return dtype same as input #12423
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs that k-means accept float32 to be fixed. It will be fixed in #11950 |
But |
|
Well that's what I hoped but fixing this currently breaks k-means because it expects the dtype of the input norms to be float64. And I don't see the point to fix the k-means part here since it will involve parts of code that I removed in #11950. What's your opinion ? |
|
It's up to you, we can also postpone it until your PR on K-Means is merged if you find it preferable.. |
|
ok I'll check if it's an easy fix in kmeans :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12422
Ensure that the norms returned by row_norms have the same dtype as their input, for dense and sparse input.