Skip to content

Improve warning reporting in LARS test #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2019
Merged

Improve warning reporting in LARS test #12597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afaf063
improve warning reporting
ogrisel Nov 15, 2018
4d3d87d
Merge branch 'master' into lars-better-warnings
ogrisel May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions sklearn/linear_model/tests/test_least_angle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,16 +451,23 @@ def test_lars_cv():
assert not hasattr(lars_cv, 'n_nonzero_coefs')


@pytest.mark.filterwarnings('ignore::FutureWarning')
def test_lars_cv_max_iter():
with warnings.catch_warnings(record=True) as w:
def test_lars_cv_max_iter(recwarn):
warnings.simplefilter('always')
with np.errstate(divide='raise', invalid='raise'):
X = diabetes.data
y = diabetes.target
rng = np.random.RandomState(42)
x = rng.randn(len(y))
X = diabetes.data
X = np.c_[X, x, x] # add correlated features
lars_cv = linear_model.LassoLarsCV(max_iter=5)
lars_cv = linear_model.LassoLarsCV(max_iter=5, cv=5)
lars_cv.fit(X, y)
assert len(w) == 0
# Check that there is no warning in general and no ConvergenceWarning
# in particular.
# Materialize the string representation of the warning to get a more
# informative error message in case of AssertionError.
recorded_warnings = [str(w) for w in recwarn]
assert recorded_warnings == []


def test_lasso_lars_ic():
Expand Down