don't set check_pickle on new joblib on python2.7 #12645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Nov 22, 2018
tomMoral
reviewed
Nov 22, 2018
| delayed_query = delayed(_tree_query_parallel_helper, | ||
| check_pickle=False) | ||
| check_pickle=check_pickle) |
There was a problem hiding this comment.
I am not sure why we have a different behavior with python2.7 here.
Shouldn't is be only dependent on the version of joblib?
There was a problem hiding this comment.
You introduced this in #12172 because in 2.7 balltree is not picklable (according to your issue description)
There was a problem hiding this comment.
I did not realize I was to blame for this. Yes indeed it is needed.
Sorry for the noise.
jnothman
pushed a commit
that referenced
this pull request
Nov 22, 2018
amueller
added a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 14, 2018
amueller
added a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 17, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12643.
too late/cold here for a non-regression test, also not sure if we test that combination anywhere.