BUG: fix check_array on pandas Series with custom dtype (eg categorical) #12706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinhanmin2014
approved these changes
Dec 1, 2018
| .................... | ||
|
|
||
| - |Fix| Calling :func:`utils.check_array` on `pandas.Series` with categorical | ||
| data, which raised an error in 0.20.0, now returns the expected output again. |
There was a problem hiding this comment.
categorical data -> something like pandas custom dtype? though I'm not able to come up with another application scenario.
There was a problem hiding this comment.
Sorry, I seem to have missed this comment.
There was a problem hiding this comment.
I think it's not important :)
eamanu
approved these changes
Dec 2, 2018
jnothman
approved these changes
Dec 3, 2018
jnothman
approved these changes
Dec 3, 2018
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 14, 2018
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 17, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…ategorical) (scikit-learn#12706)" This reverts commit 0de50b4.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…ategorical) (scikit-learn#12706)" This reverts commit 0de50b4.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12699
Related to #12625