Skip to content

improve TfidfVectorizer documentation #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

improve TfidfVectorizer documentation #12811

wants to merge 12 commits into from

Conversation

reshamas
Copy link
Member

Referencing PR / Issue

This closes #12204
This also closes #6766 and closes #9369

Note

This adds more information in the TfidfVectorizer documentation. It now includes comments about CountVectorizer and TfidfTransformer.

cc: @blooraspberry
#wimlds

ThaliaBarrera and others added 11 commits September 29, 2018 13:08
@ThaliaBarrera
Added example to sklearn.decomposition.DictionaryLearning
9a794df
@ThaliaBarrera
Added example to sklearn.decomposition.DictionaryLearning
8827a24
@ThaliaBarrera
corrected n_components for example to sklearn.decomposition.Dictionar…
1d3211b 
…yLearning
@ThaliaBarrera
corrected n_components and output for example to sklearn.decompositio…
9b413eb 
…n.DictionaryLearning
indented matrix lines, formatted long decimal
1e807e2
fixed formatting of matrix items
2925d75
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
00d067e 
…into decomp_ex
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
115c155 
…into decomp_ex
added '# doctest: +ELLIPSIS' to example
c3fff1b
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …
bac76de 
…into decomp_ex
added 2 spaces before comment on doctest
9ddf6fb
@reshamas reshamas changed the title tfidfvectorizer documentation improve TfidfVectorizer documentation Dec 18, 2018
@reshamas
Copy link
Member Author

I was supposed to push this file: sklearn/feature_extraction/text.py
but it looks like I pushed another file: sklearn/decomposition/dict_learning.py

Not sure how to clean this up? When I type git push origin tdidf_doc, I get this:

(sklearndev) ➜  scikit-learn git:(tdidf_doc) git push origin tdidf_doc                      
To github.com:reshamas/scikit-learn.git
 ! [rejected]            tdidf_doc -> tdidf_doc (non-fast-forward)
error: failed to push some refs to 'git@github.com:reshamas/scikit-learn.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@jnothman
Copy link
Member

here a force push (git push -f) might be approprite

@reshamas reshamas mentioned this pull request Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TfidfVectorizer documentation doesn't track TfidfTransformer
3 participants
@reshamas @jnothman @ThaliaBarrera