Skip to content

Reduce precision requirements for float32 PCA #12825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2018
Merged

Reduce precision requirements for float32 PCA #12825

merged 2 commits into from
Dec 19, 2018

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Dec 19, 2018 •
edited
Loading

Fixes #12823, building on #12824 to run tests in mac

  • check if tests now pass
  • revert travis changes before merge

@jnothman
Copy link
Member Author

(we expect KMeans fit_predict tests to fail here)

@qinhanmin2014
Copy link
Member

Hmm, kmeans tests pass, the travis failure is due to #12799, not related.

@jnothman
Copy link
Member Author

But suggests that this solves the issue in 0.20.2

qinhanmin2014
qinhanmin2014 approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment (e.g., XXX: test fails on mac when decimal=5 due to changes in scipy)

@jnothman jnothman merged commit 2e98a9c into scikit-learn:master Dec 19, 2018
jnothman added a commit that referenced this pull request Dec 19, 2018
@jnothman
Reduce precision requirements for float32 PCA (#12825)
57e058e 
Fixes #12823
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
@jnothman @adrinjalali
Reduce precision requirements for float32 PCA (scikit-learn#12825)
b1ed421 
Fixes scikit-learn#12823
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@jnothman
Reduce precision requirements for float32 PCA (scikit-learn#12825)
877b963 
Fixes scikit-learn#12823
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert " Reduce precision requirements for float32 PCA (scikit-learn#…
ac32450 
…12825)"

This reverts commit 877b963.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert " Reduce precision requirements for float32 PCA (scikit-learn#…
f3517a1 
…12825)"

This reverts commit 877b963.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jnothman @koenvandevelde
Reduce precision requirements for float32 PCA (scikit-learn#12825)
65743ed 
Fixes scikit-learn#12823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnothman @qinhanmin2014