Skip to content

TST Manually scramble the indices in svm tests #12890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2019
Merged

TST Manually scramble the indices in svm tests #12890

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bef3ba
[scipy-dev] manually scramble the indices
qinhanmin2014 Dec 30, 2018
1452233
review comment
qinhanmin2014 Jan 1, 2019
d8d01bf
[scipy-dev] review comment
qinhanmin2014 Jan 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions sklearn/svm/tests/test_sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,20 @@ def test_unsorted_indices():
# make sure dense and sparse SVM give the same result
assert_array_almost_equal(coef_dense, coef_sorted.toarray())

X_sparse_unsorted = X_sparse[np.arange(X.shape[0])]
X_test_unsorted = X_test[np.arange(X_test.shape[0])]
# reverse each row's indices
def scramble_indices(X):
new_data = []
new_indices = []
for i in range(1, len(X.indptr)):
row_slice = slice(*X.indptr[i - 1: i + 1])
new_data.extend(X.data[row_slice][::-1])
new_indices.extend(X.indices[row_slice][::-1])
return sparse.csr_matrix((new_data, new_indices, X.indptr),
shape=X.shape)

X_sparse_unsorted = scramble_indices(X_sparse)
X_test_unsorted = scramble_indices(X_test)

# make sure we scramble the indices
assert not X_sparse_unsorted.has_sorted_indices
assert not X_test_unsorted.has_sorted_indices

Expand Down