Skip to content

[MRG] DOC: How to deal with stalled PR #12894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2019
Merged

[MRG] DOC: How to deal with stalled PR #12894

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90a1be0
DOC: instructions for stalled PRs
GaelVaroquaux Dec 30, 2018
8ee509c
DOC: topic -> sections
GaelVaroquaux Dec 30, 2018
488699a
DOC: reword stalled PRs
GaelVaroquaux Jan 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion doc/developers/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,8 @@ and Cython optimizations.
<https://astropy.readthedocs.io/en/latest/development/workflow/development_workflow.html>`_
sections.

.. topic:: Continuous Integration (CI)
Continuous Integration (CI)
............................

* Travis is used for testing on Linux platforms
* Appveyor is used for testing on Windows platforms
Expand All @@ -389,6 +390,40 @@ and Cython optimizations.
[doc build] Docs built including example gallery plots
====================== ===================

Stalled pull requests
......................

As contributing a feature can be a lengthy process, some
pull requests appear inactive but unfinished. In such a case, taking
them over is a great service for the project.

A good etiquette to take over is:

* **Determine if a PR is stalled**

* A pull request may have the label "stalled" or "help wanted" if we
have already identified it as a candidate for other contributors.

* To decide whether an inactive PR is stalled, ask the contributor if
she/he plans to continue working on the PR in the near future.
Failure to respond within 2 weeks with an activity that moves the PR
forward suggests that the PR is stalled and will result in tagging
that PR with "help wanted".

Note that if a PR has received earlier comments on the contribution
that have had no reply in a month, it is safe to assume that the PR
is stalled and to shorten the wait time to one day.

After a sprint, follow-up for un-merged PRs opened during sprint will
be communicated to participants at the sprint, and those PRs will be
tagged "sprint". PRs tagged with "sprint" can be reassigned or
declared stalled by sprint leaders.

* **Taking over a stalled PR**: To take over a PR, it is important to
comment on the stalled PR that you are taking over and to link from the
new PR to the old one. The new PR should be created by pulling from the
old one.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If appropriate? Sometimes the old PR doesn't contain anything useful, in particular if the issue has been misunderstood.


.. _new_contributors:

Issues for New Contributors
Expand Down