Skip to content

Conversation

qinhanmin2014
Copy link
Member

The original version no longer works, I think.

Copy link
Contributor

@albertcthomas albertcthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also +1 for this change.

@qinhanmin2014
Copy link
Member Author

thanks for the review, I've updated accordingly

@albertcthomas
Copy link
Contributor

thanks @qinhanmin2014

@jnothman jnothman merged commit cdfb572 into scikit-learn:master Jan 7, 2019
@qinhanmin2014 qinhanmin2014 deleted the contributing-doc branch January 15, 2019 14:55
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Feb 19, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants