Skip to content

EXA Use cv=5 instead of cv=10 in plot_validation_curve.py #12929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2019
Merged

EXA Use cv=5 instead of cv=10 in plot_validation_curve.py #12929

merged 1 commit into from
Jan 7, 2019

Conversation

qinhanmin2014
Copy link
Member

@qinhanmin2014 qinhanmin2014 commented Jan 5, 2019 •
edited
Loading

cv=5 is faster (reduce run time from ~30s to ~13s) and more consistent with our default.
It produces very similar results (I'll post the result after Circle finishes)
master:
sphx_glr_plot_validation_curve_001
this PR:
sphx_glr_plot_validation_curve_001 1

rth
rth approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard deviation doesn't appear to increase too much indeed.

ogrisel
ogrisel approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@ogrisel ogrisel merged commit 9acc606 into scikit-learn:master Jan 7, 2019
@qinhanmin2014 qinhanmin2014 deleted the example-time branch January 7, 2019 14:35
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Feb 19, 2019
@qinhanmin2014 @jnothman
EXA Use cv=5 instead of cv=10 in plot_validation_curve.py (scikit-lea…
dba3d98 
…rn#12929)
@qinhanmin2014 qinhanmin2014 mentioned this pull request Mar 4, 2019
Closed
7 tasks
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@qinhanmin2014
EXA Use cv=5 instead of cv=10 in plot_validation_curve.py (scikit-lea…
81bd12e 
…rn#12929)
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "EXA Use cv=5 instead of cv=10 in plot_validation_curve.py (sc…
de42962 
…ikit-learn#12929)"

This reverts commit 81bd12e.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "EXA Use cv=5 instead of cv=10 in plot_validation_curve.py (sc…
072cdfa 
…ikit-learn#12929)"

This reverts commit 81bd12e.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@qinhanmin2014 @koenvandevelde
EXA Use cv=5 instead of cv=10 in plot_validation_curve.py (scikit-lea…
09e806b 
…rn#12929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinhanmin2014 @ogrisel @rth