[WIP] Added a style hypens: none to <p> tag of <div> parent whose classname is section
#12944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s name is section is selected
jnothman
reviewed
Jan 9, 2019
|
parameter named and type specs do not appear in a as far as I can see. How have you been testing these changes? |
|
The generated HTML is of this form. If you do a CTRL + F The way I tested it was adding this part of the CSS and |
|
While it is possible that hyphenation is generally not great in the
documentation, I think we should try to restrict this change as much as
possible to parameter listings, or similar <dl> listings. Where is the
hyphenation rule that we are trying to override defined?
|
|
The only places I find the keyword |
|
The hyphenation CSS comes from
https://github.com/sphinx-doc/sphinx/blob/master/sphinx/themes/basic/static/basic.css_t
and is specifically applied to div.body p, div.body dd, div.body li,
div.body blockquote. Perhaps we should be disabling it altogether. Or just
for dd. Or just for dd in numpydoc listing (approximately: div.body
.field-list dd).
|
hypens: none to <p> tag of <div> parent whose classname is sectionhypens: none to <p> tag of <div> parent whose classname is section
is provided and if it is zero, negate the score we added in the previous line
jnothman
reviewed
Mar 11, 2019
| # If sample_weight are non default AND sample_weight[i] is 0 | ||
| # negative the score by the one that we added above. | ||
| if sample_weight and not sample_weight[i]: | ||
| out -= 1 |
There was a problem hiding this comment.
I don't think this change is relevant to the current pull request
|
Are you still interested in finishing this up? |
|
Closed in #15499, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12941
What does this implement/fix? Explain your changes.
Ensures that the hyphens
-are not generated when changing the size of the browser, having these hyphens cause confusion since they change the parameter entries of a specific sklearn object/function. I specifically selected all paragraphs under thediv class = sectionsince this is where the documentation text is entered inAny other comments?
div.section dt {hyphens: none}did not make the changes required.