MAINT Run pyupgrade following Python2 deprecation #12997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Jan 17, 2019
| @@ -90,7 +90,7 @@ | |||
|
|
|||
| score_difference = non_nested_scores - nested_scores | |||
|
|
|||
| print("Average difference of {0:6f} with std. dev. of {1:6f}." | |||
| print("Average difference of {:6f} with std. dev. of {:6f}." | |||
There was a problem hiding this comment.
Is this intentional? Not that I actually care ;)
There was a problem hiding this comment.
I have not bothered reverting a few such changes, as long as there are no 500 lines of those, I'm hoping it wouldn't matter much.
amueller
approved these changes
Jan 17, 2019
|
Maybe merge #8022 first ;) |
|
Thanks for the review!
Sure, let's try to. |
qinhanmin2014
approved these changes
Feb 8, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #12948
Changes are similar to what was done in #12639 and #12812
A few more maintenance changes following dropping Python 2 support. See the parent PR for more context. This is a significantly shortened version to 220 lines diff from 700 originally, but there may still be a few cosmetic changes that I missed.