[MRG] DOC Adds explicit reference to clang #13093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought it wasn't necessary here because these steps are when you have to rely on the default apple-clang compiler, meaning you don't have another compiler, but why not. It can't hurt :) |
jeremiedbb
approved these changes
Feb 5, 2019
jnothman
approved these changes
Feb 5, 2019
|
Fair enough. Thanks @thomasjpfan |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 6, 2019
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 7, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 19, 2019
jnothman
added a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 19, 2019
This reverts commit e5e8546.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit cd67217.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit cd67217.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Minor update to #13053 in docs.
What does this implement/fix? Explain your changes.
Adds
/usr/bin/to explicitly reference the system clang. This is to make sure the system clang is used and not clang from something like anaconda.