FIX Correct the definition of gamma=scale in svm
#13221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinhanmin2014
commented
Feb 22, 2019
| @@ -1710,19 +1710,23 @@ def test_deprecated_grid_search_iid(): | |||
| depr_message = ("The default of the `iid` parameter will change from True " | |||
| "to False in version 0.22") | |||
| X, y = make_blobs(n_samples=54, random_state=0, centers=2) | |||
| grid = GridSearchCV(SVC(gamma='scale'), param_grid={'C': [1]}, cv=3) | |||
| grid = GridSearchCV(SVC(gamma='scale', random_state=0), | |||
There was a problem hiding this comment.
We do not always warn.
scikit-learn/sklearn/model_selection/_search.py
Lines 795 to 813 in d19a5dc
| @@ -87,9 +87,9 @@ def test_svc(): | |||
| kernels = ["linear", "poly", "rbf", "sigmoid"] | |||
| for dataset in datasets: | |||
| for kernel in kernels: | |||
| clf = svm.SVC(gamma='scale', kernel=kernel, probability=True, | |||
| clf = svm.SVC(gamma=1, kernel=kernel, probability=True, | |||
There was a problem hiding this comment.
numerical issue here and below
X = np.array([[-2, -1], [-1, -1], [-1, -2], [1, 1], [1, 2], [2, 1]])
X_sp = sparse.lil_matrix(X)
Y = [1, 1, 1, 2, 2, 2]
clf = svm.SVC(gamma='scale', kernel=kernel, probability=True,
random_state=0, decision_function_shape='ovo')
sp_clf = svm.SVC(gamma='scale', kernel=kernel, probability=True,
random_state=0, decision_function_shape='ovo')
clf.fit(X, Y)
print(clf._gamma)
print(clf.support_)
sp_clf.fit(X_sp, Y)
print(sp_clf._gamma)
print(sp_clf.support_)
# 0.25
# [0 1 3 4]
# 0.25000000000000006
# [1 2 3 5]
qinhanmin2014
commented
Feb 22, 2019
| @@ -344,7 +344,7 @@ once will overwrite what was learned by any previous ``fit()``:: | |||
| max_iter=-1, probability=False, random_state=None, shrinking=True, | |||
| tol=0.001, verbose=False) | |||
| >>> clf.predict(X_test) | |||
| array([1, 0, 1, 1, 0]) | |||
| array([0, 0, 0, 1, 0]) | |||
There was a problem hiding this comment.
these samples are generated randomly (maybe we should avoid doing so in the tutorial?)
ogrisel
approved these changes
Feb 22, 2019
|
lgtm (but github doesn't let me click approve?) |
Will soon open a PR to update the tutorial.
Also +0 from my side and this is out of the scope of this PR. Maybe open an issue/PR if someone wants it? |
jnothman
approved these changes
Feb 24, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 24, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Mar 19, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Apr 23, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…arn#13221)" This reverts commit 7d8830d.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…arn#13221)" This reverts commit 7d8830d.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 25, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 22, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 5, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 11, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 1, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jan 10, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jan 30, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jan 30, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Feb 27, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Mar 12, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Apr 17, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 3, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 30, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 5, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 5, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 5, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 15, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 28, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Dec 12, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Feb 25, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Feb 25, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Mar 27, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 15, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 23, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 10, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 15, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 14, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 29, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12741
See #13186 (comment):
And I'm wondering whether it's possible to solve #12741 in 0.20.3 by changing the definition of
gamma='scale'directly, since it's introduced erroneously in 0.20. This is an embarrassing mistake and I think it'll be much more difficult to solve it in 0.21.X (maybe at that time we'll need to deprecate scale and introduce another option).