Skip to content

DOC Avoid training/predicting on random dataset in the tutorial #13234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2019
Merged

DOC Avoid training/predicting on random dataset in the tutorial #13234

merged 2 commits into from
Mar 4, 2019

Conversation

qinhanmin2014
Copy link
Member

@rth rth mentioned this pull request Feb 25, 2019
Closed
@adrinjalali
Copy link
Member

tests failing, but looks good.

@qinhanmin2014
Copy link
Member Author

qinhanmin2014 commented Mar 4, 2019 •
edited
Loading

tests failing, but looks good.

thanks for the review, test failures are irrelevant, CIs are green now :)

adrinjalali
adrinjalali approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qinhanmin2014

@qinhanmin2014
Copy link
Member Author

I think I have enough confidence to merge this.

@qinhanmin2014 qinhanmin2014 merged commit 1a23be1 into scikit-learn:master Mar 4, 2019
@qinhanmin2014 qinhanmin2014 deleted the tutorial branch March 17, 2019 06:53
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@qinhanmin2014
DOC Avoid training/predicting on random dataset in the tutorial (scik…
324ab2e 
…it-learn#13234)
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC Avoid training/predicting on random dataset in the tutori…
c518ded 
…al (scikit-learn#13234)"

This reverts commit 324ab2e.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC Avoid training/predicting on random dataset in the tutori…
3af5ee3 
…al (scikit-learn#13234)"

This reverts commit 324ab2e.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@qinhanmin2014 @koenvandevelde
DOC Avoid training/predicting on random dataset in the tutorial (scik…
1c68f78 
…it-learn#13234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinhanmin2014 @adrinjalali