Skip to content

MNT Remove failed tests in extract_patches_2d #13238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019
Merged

MNT Remove failed tests in extract_patches_2d #13238

merged 1 commit into from
Feb 25, 2019

Conversation

qinhanmin2014
Copy link
Member

See #13152, close if someone can solve the issue completely.
The example is still good IMO and I guess we don't want CIs to be red during the sprint?
Tagging as blocker. ping @rth

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a temporary workaround for the sprint this should work. Thanks @qinhanmin2014 !

@agramfort agramfort merged commit 21fcc44 into scikit-learn:master Feb 25, 2019
@agramfort
Copy link
Member

thx @qinhanmin2014

@qinhanmin2014 qinhanmin2014 deleted the test-failure branch February 25, 2019 12:32
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants