Follow force_all_finite for object dtype in check_array #13254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
reviewed
Feb 25, 2019
|
Do you want to modify all estimators which are in this case as well? |
|
Question here: do we want to check for To be fully consistent, we should probably do that, since we check it for numeric data. But in practice, I suppose it will hardly ever come up (as opposed to np.nan in object dtype data), and checking it for object dtype is also much less efficient than checking it for float dtype. So from practical point of view, we could also just document it in |
|
Happy to not worry about inf in object dtype... |
jnothman
approved these changes
Feb 28, 2019
agramfort
approved these changes
Feb 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13254)" This reverts commit 162d431.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…cikit-learn#13254)" This reverts commit 162d431.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to resolve part of #12148.
Currently,
check_arraydoes not check for nan/inf when the data is object dtype. But eg in OneHotEncoder, this is actually needed, and there some additional custom code was added after callingcheck_array. This PR basically moves that intocheck_array.For now, I only check for
np.nan, and not yetnp.inf.