Clean-up warnings from tests #13262
Closed
Clean-up warnings from tests #13262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Feb 25, 2019
|
@maikia, is this PR meant to be doing more than ignoring SparseEfficiencyWarning? I'm wondering whether you have extra commits from other work here. |
…for untreated warnings
jnothman
reviewed
Feb 26, 2019
…est where it tests for alpha too small
…n warning in setup
|
Are you still working on this? Is this still relevant? |
|
A lot of things have changed since this pull request, but there are still warnings in the tests (in particular I have checked 34 |
|
Given the many changes, I'll say to close this one and have multiple PRs that resolves warnings one test at a time. Sometimes resolving the warning can be quite involved which calls for a single PR to fix each test. @maikia Thank you again for working on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of warnings generated during testing. Some of them might be ignored but some might be more important. Here I add ignore to the SparseEfficiencyWarning in test_validation
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?