Hotfix Skip non deterministic tests on PowerPC #13323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because I have not managed to find a PowerPC machine, it's a bit difficult to test |
This was referenced Feb 28, 2019
Merged
jnothman
reviewed
Feb 28, 2019
sklearn/base.py
Outdated
| class _UnstableOn32BitMixin(object): | ||
| """Mark estimators that are non-determinstic on 32bit.""" | ||
| class _UnstableArchMixin(object): | ||
| """Mark estimators that are non-determinstic on 32bit and PowerPC""" |
agramfort
approved these changes
Feb 28, 2019
jnothman
approved these changes
Feb 28, 2019
|
Thanks @rth h |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…arn#13323)" This reverts commit b76763e.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…arn#13323)" This reverts commit b76763e.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to work around #13051 by extending the tests currently considered non determinisitic on 32 bit arch to PowerPC as well.
Closes #13051
The
platform.machinesettings can be seen e.g. here.Ideally, it would be good to understand why these are non-deterministic (on 32 bit arch as well) but meanwhile since we are not officially supporting PowerPC this aims to avoid new bug reports from debian maintainers while packaging scikit-learn, for tests that we deem acceptable to skip on 32 bit arch.