Skip to content

[WIP] Replace externals.six.integer_types with int #13342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2019
Merged

[WIP] Replace externals.six.integer_types with int #13342

merged 2 commits into from
Mar 1, 2019

Conversation

jrbourbeau
Copy link
Contributor

Reference Issues/PRs

six dependencies were removed in #12639 and the use of externals.six was deprecated in #12916

What does this implement/fix? Explain your changes.

This PR replaces references to externals.six.integer_types with int in order to avoid raising a DeprecationWarning

Any other comments?

@jrbourbeau jrbourbeau mentioned this pull request Feb 28, 2019
Merged
ogrisel
ogrisel reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, just a nitpick otherwise it would have been too easy :)

@qinhanmin2014 qinhanmin2014 merged commit a547311 into scikit-learn:master Mar 1, 2019
@jrbourbeau jrbourbeau deleted the remove-six-reference branch March 1, 2019 00:48
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@jrbourbeau
MNT Replace externals.six.integer_types with int (scikit-learn#13342)
6673c7b
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MNT Replace externals.six.integer_types with int (scikit-lear…
086ed8e 
…n#13342)"

This reverts commit 6673c7b.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MNT Replace externals.six.integer_types with int (scikit-lear…
1254035 
…n#13342)"

This reverts commit 6673c7b.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jrbourbeau @koenvandevelde
MNT Replace externals.six.integer_types with int (scikit-learn#13342)
63394b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel left review comments

@agramfort agramfort agramfort approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrbourbeau @ogrisel @agramfort @qinhanmin2014