Skip to content

[MRG+1] DOC: add to docstring that check_array does not check for np.inf for object dtype #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Follow-up on #13254, as that was merged before I could add a docstring note.

@GaelVaroquaux GaelVaroquaux changed the title DOC: add to docstring that check_array does not check for np.inf for object dtype [MRG+1] DOC: add to docstring that check_array does not check for np.inf for object dtype Mar 1, 2019
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merge

@agramfort
Copy link
Member

@jnothman merge if you're happy.

@jnothman jnothman merged commit a304db9 into scikit-learn:master Mar 4, 2019
@jorisvandenbossche jorisvandenbossche deleted the check-array-object-doc branch March 4, 2019 16:56
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants