WIP Modifying nmf.py for accepting mini-batches #13386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
February 28, 2019 10:27
…ent) and benchmart file (WIP)
|
Result of the benchmark in a training set of size 500k. The loss is calculated on 10k test samples |
|
The advantage of the batch mode is that 'fit' calls 'fit_transform', so it automatically transforms the training data. This is not the case for the online method, so a 'transform' time should be considered |
|
@pcerda are you still working on this? |
|
I will try to pitch in. |
|
I'm currently working on something else. |
|
Working on it in #16948. |
|
I am closing this PR because #16948 is merged which includes the proposed feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#13308
What does this implement/fix? Explain your changes.
Modification of the NMF class to accept mini batches. For the moment, it works only with
solver='mu'andbeta_loss='kullback-leibler.I also added the benchmark code.
Any other comments?