[MRG] Fix CircleCI builds by using sphinx-gallery 0.2.0 #13513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphinx-gallery 0.3 has changed the figure numbering in some edge cases. [doc build]
052a278 to
1df4b90
Compare
|
In the CircleCI build artifacts in this PR, you can check that |
|
Are we merging this? I thought we were excited about the new release and it was fixing some of our issues. |
|
I personally kinda prefer the alternative of fixing them on our side. |
|
Yeah, I'd rather remove plt.figure(0).
|
|
Closed in favour of #13527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sphinx-gallery 0.3 has changed the figure numbering in some edge cases. I'll create an issue in sphinx-gallery to track this problem (done in sphinx-gallery/sphinx-gallery#464) but I think in the mean time the simplest is to use the previous sphinx-gallery release.
Note: sphinx-gallery 0.3 has been released 3 days ago which does match the failures in master on CircleCI which started 2 days ago, e.g. https://circleci.com/gh/scikit-learn/scikit-learn/52538