-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
[MRG] Fix for sphinx-gallery 0.3.1 + 404 errors on Debian Jessie packages #13527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Fix for sphinx-gallery 0.3.1 + 404 errors on Debian Jessie packages #13527
Conversation
Figure numbering have been changed to ignore matplotlib figure number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hair to give it a try if it passes locally
This docker image uses Debian stretch and fixes the problems seen with apt-get update with Debian jessie.
I pushed a simple fix for the CircleCI problem with jessie (circleci/python3.6 uses Debian stretch rather than Debian jessie and should get rid of the problem):
|
Running examples/ensemble/plot_feature_transformation.py
94:plt.figure(1)
107:plt.figure(2)
examples/cluster/plot_affinity_propagation.py
49:plt.figure(1)
examples/cluster/plot_color_quantization.py
85:plt.figure(1)
91:plt.figure(2)
97:plt.figure(3)
examples/cluster/plot_adjusted_for_chance_measures.py
74:plt.figure(1)
104:plt.figure(2)
examples/cluster/plot_kmeans_digits.py
108:plt.figure(1)
examples/cluster/plot_mean_shift.py
45:plt.figure(1)
examples/gaussian_process/plot_gpc_isoprobability.py
67:fig = plt.figure(1)
examples/linear_model/plot_lasso_coordinate_descent_path.py
49:plt.figure(1)
64:plt.figure(2)
77:plt.figure(3)
examples/feature_selection/plot_feature_selection.py
43:plt.figure(1)
examples/manifold/plot_mds.py
61:fig = plt.figure(1)
examples/exercises/plot_iris_exercise.py
42: plt.figure(fig_num)
examples/applications/plot_outlier_detection_housing.py
80: plt.figure(1)
86: plt.figure(2)
97:plt.figure(1) # two clusters
119:plt.figure(2) # "banana" shape |
Seems to be needed to convert doc/images/iris.svg.
curious, how did you find which fonts it needs? |
Could you please also do a |
[doc build]
a0388c2
to
602de82
Compare
@thomasjpfan basically the problem with sphinx-gallery 0.3.1 only appears when your use figure numbers that don't match the default matplotlib figure numbering (i.e. 1, 2, 3, ..., @adrinjalali I used I pushed a commit fixing an example I missed before and |
The CircleCI build is green and the build doc looks fine AFAICT (I compared the generated doc in this PR vs the dev doc visually, using https://53032-843222-gh.circle-artifacts.com/0/doc/_changed.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
FYI the CircleCI is green on master too: https://circleci.com/gh/scikit-learn/scikit-learn/53038 (you never know the pdf build is more finicky sometimes ...). |
Thanks for fixing this everyone |
…kages (scikit-learn#13527) * Fix for sphinx-gallery 0.3.1. Figure numbering have been changed to ignore matplotlib figure number. * Use circleci/3.6 image. This docker image uses Debian stretch and fixes the problems seen with apt-get update with Debian jessie. * Install additional fonts. Seems to be needed to convert doc/images/iris.svg. * Another missed example using figure number 0. [doc build]
…ssie packages (scikit-learn#13527)" This reverts commit 646cdd5.
…ssie packages (scikit-learn#13527)" This reverts commit 646cdd5.
…kages (scikit-learn#13527) * Fix for sphinx-gallery 0.3.1. Figure numbering have been changed to ignore matplotlib figure number. * Use circleci/3.6 image. This docker image uses Debian stretch and fixes the problems seen with apt-get update with Debian jessie. * Install additional fonts. Seems to be needed to convert doc/images/iris.svg. * Another missed example using figure number 0. [doc build]
…kages (#13527) * Fix for sphinx-gallery 0.3.1. Figure numbering have been changed to ignore matplotlib figure number. * Use circleci/3.6 image. This docker image uses Debian stretch and fixes the problems seen with apt-get update with Debian jessie. * Install additional fonts. Seems to be needed to convert doc/images/iris.svg. * Another missed example using figure number 0. [doc build]
sphinx-gallery 0.3 has changed the output figure numbering in some edge cases (mostly 0.3.1 ignores matplotlib figure numbers see sphinx-gallery/sphinx-gallery#464 for more details). This PR replaces #13513 and should fix the CircleCI build failures in master, e.g. circleci.com/gh/scikit-learn/scikit-learn/52538.