MAINT Remove imports from sklearn.utils._joblib #13676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be reviewed. The codecov patch failure is probably not relevant. |
adrinjalali
approved these changes
Jun 18, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* Remove sklearn.utils._joblib imports * Lint * More fixes
MariaEriksson
added a commit
to MariaEriksson/scona
that referenced
this pull request
Dec 14, 2020
An earlier scikit-learn version was specified to take into account the fact that sklearn.utils._joblib has been removed from more recent versions. https://stackoverflow.com/questions/54965751/modulenotfounderror-no-module-named-sklearn-utils-joblib scikit-learn/scikit-learn#13676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #13531 removing imports from
sklearn.utils._joblibin favor of using joblib directly.TODO:
check if(can be done in a subsequent PR)sklearn.utils._joblibcan be removed altogetherdeprecated all remaining joblib aliases in(can be done in another PR)sklearn.utils