Skip to content

[MRG] removed close_figure helper #13730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2019
Merged

[MRG] removed close_figure helper #13730

merged 1 commit into from
Apr 26, 2019

Conversation

NicolasHug
Copy link
Member

close_figure() helper was introduced in #12599 but it's actually completely redundant with pyplot.close().

We should remove it before 0.21.

@NicolasHug NicolasHug mentioned this pull request Apr 26, 2019
Merged
adrinjalali
adrinjalali approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasHug NicolasHug added this to the 0.21 milestone Apr 26, 2019
thomasjpfan
thomasjpfan approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit b8ef9a9 into scikit-learn:master Apr 26, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@NicolasHug
MAINT removed close_figure helper (scikit-learn#13730)
e89e334
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MAINT removed close_figure helper (scikit-learn#13730)"
ee69736 
This reverts commit e89e334.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MAINT removed close_figure helper (scikit-learn#13730)"
2f6a7fb 
This reverts commit e89e334.
marcelobeckmann pushed a commit to marcelobeckmann/scikit-learn that referenced this pull request May 1, 2019
@NicolasHug @marcelobeckmann
MAINT removed close_figure helper (scikit-learn#13730)
57693b1
marcelobeckmann pushed a commit to marcelobeckmann/scikit-learn that referenced this pull request May 1, 2019
@NicolasHug @marcelobeckmann
MAINT removed close_figure helper (scikit-learn#13730)
b3ad764
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@NicolasHug @koenvandevelde
MAINT removed close_figure helper (scikit-learn#13730)
70064da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.21
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @adrinjalali @thomasjpfan