[MRG] DOC Added version information for PCA.singular_values_ #13776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCA.singular_values_ is added in 0.19; adding this information to the documentation.
In decomposition/pca.py, removed the whitespaces from the empty line introduced by the previous commit.
jnothman
approved these changes
May 4, 2019
|
Thanks |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 6, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCA.singular_values_is added in 0.19; adding this information to the documentation.Reference Issues/PRs
The feature
PCA.singular_values_has originally been implemented in #7685, however, the version information (0.19) is absent from the documentation.What does this implement/fix? Explain your changes.
Adding information about the versioning, especially suitable for the users of older versions.
Any other comments?