Skip to content

[MRG] DEP change default and deprecate iid in SearchCV #13834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2019

Conversation

glemaitre
Copy link
Member

Change the default to False for iid and deprecate it.

@glemaitre glemaitre changed the title DEP change default and deprecate iid in SearchCV [MRG] DEP change default and deprecate iid in SearchCV May 8, 2019
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is a conflict to resolve before merging.

@ogrisel ogrisel merged commit 69eb4d4 into scikit-learn:master May 9, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
hristog added a commit to hristog/dask-examples that referenced this pull request Mar 11, 2021
tl;dr `iid` has been deprecated and the updated behavior corresponds
to `iid=True`.

References:
- Deprecation warning and explanation of associated behavior:
  scikit-learn/scikit-learn#9379.
- Deprecation: scikit-learn/scikit-learn#13834.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants