Skip to content

DOC Remove experimental tag from ColumnTransformer #13835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2019
Merged

DOC Remove experimental tag from ColumnTransformer #13835

merged 2 commits into from
May 9, 2019

Conversation

qinhanmin2014
Copy link
Member

ping @jnothman

@qinhanmin2014 qinhanmin2014 added this to the 0.21 milestone May 9, 2019
jnothman
jnothman approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are happy enough with the ColumnTransformer API so far... but of course we will be proven wrong some time soon...?

@glemaitre
Copy link
Member

IMO +1. The issues that I now see are more additional features than API changes.
@jorisvandenbossche do you have any thought on this one?

ogrisel
ogrisel approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as well but would love to get @jorisvandenbossche's confirmation.

@jnothman
Copy link
Member

jnothman commented May 9, 2019 via email

@jnothman
Copy link
Member

jnothman commented May 9, 2019

I'm giving this 8 hours... if we've not heard other opinions, I think it's reasonable to merge and release.

jorisvandenbossche
jorisvandenbossche reviewed May 9, 2019
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't any major issues being reported, I think, so +1 on removing the experimental tag.

@qinhanmin2014
Copy link
Member Author

Let's merge and release.

@qinhanmin2014 qinhanmin2014 merged commit 8b1751a into scikit-learn:master May 9, 2019
@qinhanmin2014 qinhanmin2014 deleted the experimental-feature branch May 9, 2019 15:38
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 9, 2019
@qinhanmin2014 @jnothman
DOC Remove experimental tag from ColumnTransformer (scikit-learn#13835)
39c74cd
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@qinhanmin2014 @koenvandevelde
DOC Remove experimental tag from ColumnTransformer (scikit-learn#13835)
6dbb748
@rth rth mentioned this pull request Jul 24, 2019
Merged
@justmarkham justmarkham mentioned this pull request Apr 2, 2020
Merged
@lorentzenchr lorentzenchr mentioned this pull request Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

+1 more reviewer

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21
Development

Successfully merging this pull request may close these issues.
5 participants
@qinhanmin2014 @glemaitre @jnothman @ogrisel @jorisvandenbossche