NOMRG TST Skip test_ridge.test_dtype_match on MacOS #13876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recently there're more and more mysterious codecov failures, is it just my illusion? |
It's not you ^^ |
|
I'm happy with this in the absence of a better solution, thanks @qinhanmin2014. Do we want it in master, or just 0.21.X? |
jnothman
approved these changes
May 14, 2019
I'm fine with either solution, slightly prefer to keep consistent between master and 0.21.X. We can always revert if we solve the problem. |
|
So far I've included this in 0.21.1, leaving it open here
|
|
Marking this as NOMRG as I keep seeing it in the list of PRs with +1, but if I understood correctly we would rather find a better solution than this workaround for master. |
|
This error is only happening in our MacPython builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @jnothman in case you want it.