Documentation improvement #13904
Merged
Documentation improvement #13904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why the build is failing. |
qinhanmin2014
approved these changes
May 18, 2019
sklearn/preprocessing/_encoders.py
Outdated
| @@ -367,7 +367,7 @@ def _handle_deprecations(self, X): | |||
| msg = ( | |||
| "Passing 'n_values' is deprecated in version 0.20 and will be " | |||
| "removed in 0.22. You can use the 'categories' keyword " | |||
| "instead. 'n_values=n' corresponds to 'categories=[range(n)]'." | |||
| "instead. 'n_values=n' corresponds to 'categories=[range(n)] * n_features'." | |||
There was a problem hiding this comment.
sklearn/preprocessing/_encoders.py:370:80: E501 line too long (92 > 79 characters)
sklearn/preprocessing/_encoders.py
Outdated
| @@ -367,7 +367,8 @@ def _handle_deprecations(self, X): | |||
| msg = ( | |||
| "Passing 'n_values' is deprecated in version 0.20 and will be " | |||
| "removed in 0.22. You can use the 'categories' keyword " | |||
| "instead. 'n_values=n' corresponds to 'categories=[range(n)]'." | |||
| "instead. 'n_values=n' corresponds to " | |||
| "'categories = [range(n)] * n_features'." | |||
There was a problem hiding this comment.
There should be no spaces before or after the = in a function definition (see https://lintlyci.github.io/Flake8Rules/rules/E251.html).
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 21, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13791 and fixes #13881
What does this implement/fix? Explain your changes.
addes new documentation for fbeta_score and correct deprecation warning for OneHotEncoder
Any other comments?
OneHotEncoder behavior using n_values and categories seem a bit inconsistent. For n_values you just need to know the number of categories while for categories you need to know both number of values and number of features you will encode. More details in this comment.