Skip to content

[MRG] DOC: Rewrote algorithm selection part of nearest neighbours docs #13906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2019

Conversation

rlms
Copy link
Contributor

@rlms rlms commented May 19, 2019

Reference Issues/PRs

Closes #13880.

What does this implement/fix?

Improves documentation for algorithm selection of nearest neighbours page, making explanation clearer and more accurate.

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rlms this is much more clear indeed.

The CI failure is unrelated.

@rth rth merged commit eb93420 into scikit-learn:master May 20, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 21, 2019
@rlms rlms deleted the nearest-neighbours-docs branch May 22, 2019 19:49
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: nearest neighbour choice of algorithm section is unclear
3 participants