Skip to content

[MRG] Fixes test_scale_and_stability by reducing the decimal #13930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomasjpfan
Copy link
Member

This test seems to fail randomly. This PR adds decimal=4 to make the test less strict.

@thomasjpfan thomasjpfan mentioned this pull request May 23, 2019
@jnothman
Copy link
Member

Did this crop up somewhere in particular? I'm happy to throw it into the release whether or not it's essential in master.

@ogrisel
Copy link
Member

ogrisel commented May 23, 2019

On one of the windows builds of #13146.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

It's still fishy that we need to do this but fair enough.

@thomasjpfan
Copy link
Member Author

This error does not seem to be popping up anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants