Skip to content

TST avoid nose collecting train_test_split as a test #13951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2019
Merged

TST avoid nose collecting train_test_split as a test #13951

merged 1 commit into from
May 26, 2019

Conversation

jnothman
Copy link
Member

Reinstates #10223 and fixes #13943. Thanks @trevorstephens

@jnothman jnothman added this to the 0.21.3 milestone May 26, 2019
rth
rth approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging with one review as it's mostly identical to #10223 that must have been later removed by accident.

@rth rth changed the title [MRG] TST avoid nose collecting train_test_split as a test TST avoid nose collecting train_test_split as a test May 26, 2019
@rth rth merged commit f3a6a1a into scikit-learn:master May 26, 2019
jnothman added a commit to jnothman/scikit-learn that referenced this pull request Jun 24, 2019
@jnothman
TST avoid nose collecting train_test_split as a test (scikit-learn#13951
61a389a 
)
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jnothman @koenvandevelde
TST avoid nose collecting train_test_split as a test (scikit-learn#13951
18fd0f0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.3
Development

Successfully merging this pull request may close these issues.

Scikit-learn 0.21.1 strange failure using nosetests with import train_test_split
2 participants
@jnothman @rth