MAINT: use explicit value of n_jobs to avoid hangs on Windows #13970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
approved these changes
May 28, 2019
There was a problem hiding this comment.
Thanks @oleksandr-pavlyk ! This was introduced in #12961 I was under impression that oversubsription issues are handled in the last loky versions. It might be worth reporting this failing test with the environement where it is run in a new issue.
jnothman
approved these changes
May 28, 2019
|
Thanks @oleksandr-pavlyk |
@rth Actually we discovered a few days ago that it does not work :/ But the issue is known and we're trying to fix it :) |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jun 24, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion change to #13644 , where a new in 0.21 test uses
n_jobs=-1, causing test suite run on certain Windows boxes to hang #12263The change replaced
n_jobs=-1withn_jobs=4.