[MRG] Initialize MissingIndicator with error_on_new = False #13974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a non-regression test. Thanks. |
jnothman
reviewed
May 29, 2019
|
Would the test be to ensure that errors are thrown if relevant features are missing values? |
|
To test that no errors are raised if a feature has a missing value in test
but not in train, and that the transformed data is all finite.
|
jnothman
reviewed
May 30, 2019
…e IterativeImputer nonregression test and also default error_on_new to False.
|
@jnothman can you review? Thanks! |
|
Please revert the changes that are not related to the PR. |
|
Done! @thomasjpfan |
jnothman
approved these changes
Jun 2, 2019
|
Done! @jnothman. Thanks for the help/input. |
thomasjpfan
reviewed
Jun 3, 2019
|
@thomasjpfan: change being pushed up. |
NicolasHug
reviewed
Jun 3, 2019
NicolasHug
reviewed
Jun 3, 2019
|
@NicolasHug I proposed putting this is an 0.21 series bug fix release, assuming we have a couple more fixes to join if (not sure if you want the recently raised divide by zero in gradient boosting to be fixed in 0.21.3 also, for instance) |
|
Agree this should be a bug-fix release. |
|
Implemented suggestions @NicolasHug @amueller |
NicolasHug
approved these changes
Jun 13, 2019
glemaitre
reviewed
Jun 13, 2019
glemaitre
reviewed
Jun 13, 2019
|
Thank you @fhoang7! |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jun 25, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Resolves #13968
What does this implement/fix? Explain your changes.
Set error_on_new to False by default if add_indicator is True in order to suppress missing value errors in ignored features.
Any other comments?