-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] better message for pillow import error #14027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While I agree that it is better to give such a message, I think that we should be careful with the directive. Basically, we could install with brew, debian, pip, conda, etc. We could be a bit less assertive and refer to the PIL documentation:
WDYT? |
By the way, the CI failure is a new one. Never saw it before. |
We always use |
yeah I agree with @NicolasHug. We could otherwise refer to the installation docs of pytest, cython, etc. This looks good to me, thanks! |
Because people will have to read the documentation to understand what it implies to We might want to change our contribution guide, starting with an early note mentioning that we will use I think that @amueller did a similar comment on one of @thomasjpfan PR regarding the installation of pandas or matplotlib (I could not find which PR thought)
Yes but it also mentioned |
I don't mind. Feel free to push your changes |
We do have https://scikit-learn.org/stable/developers/advanced_installation.html though. The problem is that indicating For contributing instructions, I think |
That's a very fair point, I'm convinced.
|
why would we need pil? Shouldn't we use imageio? |
imageio depends on pillow so that would be 1 extra dependency in addition to pillow. |
really? but why? ok, just ignore me... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* better import error message for pillow * pillow -> Pillow * link to pillow page
Addresses #13961 (comment)
ping @adrinjalali