Skip to content

[MRG] BUG Fixes export_text with single feature #14053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jun 9, 2019

Reference Issues/PRs

Fixes #13976

What does this implement/fix? Explain your changes.

Uses None as a placeholder in feature_names_. (It is never used in print_tree_recurse when the node is a leaf).

Any other comments?

Thought of leaving this up, but a bug fix feels important enough to fix quickly.

Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@rth
Copy link
Member

rth commented Jun 13, 2019

We need a what's new entry I think?

@jnothman
Copy link
Member

Yes, please, under 0.21.3

@rth
Copy link
Member

rth commented Jun 18, 2019

Thanks @thomasjpfan !

@rth rth merged commit e2b6bff into scikit-learn:master Jun 18, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Jun 24, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range in export_text when the tree only has one feature
3 participants