[MRG] Fix NCA parameter type check #14092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
commented
Jun 14, 2019
| @@ -129,7 +129,7 @@ def test_params_validation(): | |||
| # TypeError | |||
| assert_raises(TypeError, NCA(max_iter='21').fit, X, y) | |||
| assert_raises(TypeError, NCA(verbose='true').fit, X, y) | |||
| assert_raises(TypeError, NCA(tol=1).fit, X, y) | |||
| assert_raises(TypeError, NCA(tol='1').fit, X, y) | |||
There was a problem hiding this comment.
integers are part of numbers.Real. But afaik there's not type for 'any float type but not int type'.
However, I don't see why setting tol=1 would be bad.
rth
approved these changes
Jun 14, 2019
jnothman
approved these changes
Jun 18, 2019
|
Thanks @jeremiedbb! |
|
Whoops. Forgot what's new. Please add to 0.21.3 and open a new PR. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jun 24, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14033
type check of parameters in NCA are too strict. Typically when params are part of a grid built with numpy (
linspace,arange, ...) for a grid search, the types are numpy integer or floating types.